Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc File src/kudu/util/mini_oidc.cc: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@1 PS7, Line 1: / > Done still one extra space http://gerrit.cloudera.org:8080/#/c/18473/8/src/kudu/util/mini_oidc.cc File src/kudu/util/mini_oidc.cc: http://gerrit.cloudera.org:8080/#/c/18473/8/src/kudu/util/mini_oidc.cc@105 PS8, Line 105: { : WebserverOptions opts; : opts.port = 0; : jwks_server_.reset(new Webserver(opts)); : } nit: why need parentheses? -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 09 Feb 2023 19:27:06 +0000 Gerrit-HasComments: Yes
