Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 7: (13 comments) http://gerrit.cloudera.org:8080/#/c/18473/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18473/7//COMMIT_MSG@12 PS7, Line 12: dispensor > dispenser? Done http://gerrit.cloudera.org:8080/#/c/18473/7//COMMIT_MSG@15 PS7, Line 15: reply > rely? Done http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util-test.cc@962 PS7, Line 962: true > Should this be 'false' instead? Otherwise, what's the difference between t indeed, thanks for the catch! http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util.h File src/kudu/util/jwt-util.h: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util.h@134 PS7, Line 134: std::string > Could this be 'const std::string'? Done http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h File src/kudu/util/mini_oidc.h: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@20 PS7, Line 20: > nit: remove the extra line Done http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@41 PS7, Line 41: std::string expiration_time; > nit: would be great to document this field as well no, this is not needed http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@47 PS7, Line 47: // Serves the following endpoints: > nit: for testing cluster Done http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@80 PS7, Line 80: is_valid > is_valid_key_id or is_valid_key? It refers to the JWT itself, if it's set to false, then the created JWT will be invalid. http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@85 PS7, Line 85: MiniOidcOptions > Could this be 'const MiniOidcOptions'? no, as then assigning options would not be feasible during testing http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc File src/kudu/util/mini_oidc.cc: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@1 PS7, Line 1: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@94 PS7, Line 94: oidc_server_ > What if oidc_server_ is nullptr because Start() returned an error before li Ack http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@95 PS7, Line 95: jwks_server_ > What if jwks_server_ is nullptr since the Start() method hasn't been called Ack http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.cc@110 PS7, Line 110: 'kid_1' points at a valid key, while 'kid_2' points at an > declare kKid1 and kKid2 Done -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 09 Feb 2023 15:19:30 +0000 Gerrit-HasComments: Yes
