Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 8: (2 comments) overall looks good, just a few nits http://gerrit.cloudera.org:8080/#/c/18473/8/src/kudu/util/mini_oidc.cc File src/kudu/util/mini_oidc.cc: http://gerrit.cloudera.org:8080/#/c/18473/8/src/kudu/util/mini_oidc.cc@1 PS8, Line 1: nit: as Wenzhe mentioned, there is still an extra space http://gerrit.cloudera.org:8080/#/c/18473/8/src/kudu/util/mini_oidc.cc@151 PS8, Line 151: oidc_server_->Stop(); nit: for a cleaner code consider a couple of options here: (1) prefer SIGABRT instead of SIGSEGV in debug builds: if MiniOidc::Stop() is being called when MiniOidc::Start() hasn't been called, add DCHECK() for oidc_server_ and jwks_server_ (2) enclose these xxx->Stop() calls to be under corresponding 'if (xxx)' -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 10 Feb 2023 01:55:05 +0000 Gerrit-HasComments: Yes
