Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 )
Change subject: jwt: introduce MiniOidc ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util-test.cc@962 PS7, Line 962: true Should this be 'false' instead? Otherwise, what's the difference between this and the next line? http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util.h File src/kudu/util/jwt-util.h: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/jwt-util.h@134 PS7, Line 134: std::string Could this be 'const std::string'? http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h File src/kudu/util/mini_oidc.h: http://gerrit.cloudera.org:8080/#/c/18473/7/src/kudu/util/mini_oidc.h@85 PS7, Line 85: MiniOidcOptions Could this be 'const MiniOidcOptions'? -- To view, visit http://gerrit.cloudera.org:8080/18473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e9b3bcd0946adbe4642a19c5ef1124e39632c6 Gerrit-Change-Number: 18473 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 03:38:55 +0000 Gerrit-HasComments: Yes
