Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19949/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19949/3//COMMIT_MSG@20 PS3, Line 20: This patch will validate the schema of multiple rows which belong : to the same tablet. If the schema is different, it puts them into : the different groups as different batches. > Great! This bug is a serious problem. This way seems ok and there is somet I have found another need a common schema when sending a write batch rpc. ``` static Tserver.WriteRequestPB.Builder createAndFillWriteRequestPB(List<Operation> operations) { Schema schema = operations.get(0).table.getSchema(); Tserver.WriteRequestPB.Builder requestBuilder = Tserver.WriteRequestPB.newBuilder(); requestBuilder.setSchema(ProtobufHelper.schemaToPb(schema, EnumSet.of(SchemaPBConversionFlags.SCHEMA_PB_WITHOUT_COMMENT, SchemaPBConversionFlags.SCHEMA_PB_WITHOUT_ID))); ``` If there are two different schemas, it is an error schema for some ops. So this method may not be ok. I'll think it again. -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 02 Jun 2023 07:19:33 +0000 Gerrit-HasComments: Yes
