Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@371 PS6, Line 371: // Extra batches for operations which have different table schemas. > nit: Done http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@372 PS6, Line 372: hes is used > Could you please add some comments to clearify the relationship between 'ba Done http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@413 PS6, Line 413: > nit: schemas Done http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@414 PS6, Line 414: se if (!batch.operations.is > nit: !batch.operations.isEmpty() Done http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@414 PS6, Line 414: } > It would be better to use 'else if', becaue it not possible that the 'batch Done http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@415 PS6, Line 415: eq > nit: equals ? Done http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@417 PS6, Line 417: reAllNotF > Is it possible that there are ops to be sent in schema version 1, 2, 1 ? Wh It is hard to handle this case. For example, if there are 5 operations, op1, op2, op3, op4, op5. op1 and op2 have the same schema, op2 and op4 have the same schema, op5 has a schema different from other operations. There will be 3 groups. It is high-price cost to compare the schema with others operations. Therefore here just simplify it, if found an operation with different schema, put it in extra_batch -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 14 Jun 2023 13:40:06 +0000 Gerrit-HasComments: Yes
