Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@371 PS6, Line 371: // Extra batch for operations which have a different table schema. nit: Extra batches for operations which have different table schemas. http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@372 PS6, Line 372: extraBatches Could you please add some comments to clearify the relationship between 'batches' and 'extraBatches' ? http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@413 PS6, Line 413: schema nit: schemas http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@414 PS6, Line 414: batch.operations.size() > 0 nit: !batch.operations.isEmpty() http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@414 PS6, Line 414: if It would be better to use 'else if', becaue it not possible that the 'batch' has been created above according to 'operation' and then it has a different schema, right? http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@415 PS6, Line 415: != nit: equals ? http://gerrit.cloudera.org:8080/#/c/19949/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@417 PS6, Line 417: new Batch Is it possible that there are ops to be sent in schema version 1, 2, 1 ? When sending the 3rd operation, we can reuse the 'batch' created at first time, instead of create a new batch. -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 09 Jun 2023 07:50:37 +0000 Gerrit-HasComments: Yes
