Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19949/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@371 PS3, Line 371: Extral > I guess you mean 'Extra' ? Done http://gerrit.cloudera.org:8080/#/c/19949/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@372 PS3, Line 372: extral_batches > extra_batches Done http://gerrit.cloudera.org:8080/#/c/19949/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@419 PS3, Line 419: extral_batches > every op different from batch.operations.get(0) need a write rpc? It seems I think it is hard to handle this case. For example, if there are 5 operations, op1, op2, op3, op4, op5. op1 and op2 have the same schema, op2 and op4 have the same schema, op5 has a schema different from other operations. There will be 3 groups. It is high-price cost to compare the schema with others operations. Therefore here just simplify it, if found an operation with different schema, put it in extra_batch -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 05 Jun 2023 07:22:23 +0000 Gerrit-HasComments: Yes
