Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19620/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19620/2//COMMIT_MSG@16 PS2, Line 16: wnload superblock piece by piece. A new > 1. If found superblock size is larlger than --rpc_max_message_size, downloa I got it. Currently, downloading superblock using pull mode, not push mode. Firstly, it needs to send a rpc to get the superblock size. Then you can decide to set tablet_copy_download_superblock_in_batch true or not. This needs to implement extra interface. If you choose this solution, why not set tablet_copy_download_superblock_in_batch always true. Use tablet_copy_download_superblock_in_batch always can download superblock sucessfully. Why I keep the origin one-time downloading superblock logic? Because the case of large-size superblock is not normal. Using tablet_copy_download_superblock_in_batch is more time-cost. http://gerrit.cloudera.org:8080/#/c/19620/3/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19620/3/src/kudu/tserver/tablet_copy_client.cc@325 PS3, Line 325: Substitute("Could not delete temporary superblock file $0", : superblock_path)); > If download failed, it would return in L320, right? Yes. You are right. I will move these code to line 320. If download it failed or after load it into memory, it should be deleted. http://gerrit.cloudera.org:8080/#/c/19620/3/src/kudu/tserver/tablet_copy_client.cc@334 PS3, Line 334: path, > If --encrypt_data_at_rest is not set, the superblock file will not be encry Done http://gerrit.cloudera.org:8080/#/c/19620/3/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/19620/3/src/kudu/tserver/tablet_copy_source_session.cc@322 PS3, Line 322: const string& sb_file = Substitute("/tmp/tablet_metadata-$0", tablet_id_); > You can dump the in-memory struct to a temporary file when decide to downlo Done -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 09:29:58 +0000 Gerrit-HasComments: Yes
