Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy.proto File src/kudu/tserver/tablet_copy.proto: http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy.proto@127 PS10, Line 127: // To represent that superblock is too large to download directly. > Add some comments. Done http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy_client.cc@305 PS10, Line 305: FLAGS_tablet_copy_auto_download_superblock_in_batch > If this flag is only used in tests, add a "_for_tests" postfix, the default Well, it is better to don't take it as a test flag. FLAGS_tablet_copy_auto_download_superblock_in_batch is a flag to represent the new feature, which means downloading superblock directly when superblock is small, when it is very large , then return a message to tell the client it is very large and the client begins to downloading the superblock piece by piece. If FLAGS_tablet_copy_auto_download_superblock_in_batch is false, it will return error when the superblock is very large. http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy_client.cc@335 PS10, Line 335: CHECK(resp.has_superblock()); > nit: Add a CHECK to verify resp.superblock() must has been set. Done http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/19620/10/src/kudu/tserver/tablet_copy_source_session.cc@495 PS10, Line 495: if (!superblock_tmp_path_.empty() && > if (!superblock_tmp_path_.empty() && ...) Done -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 05 Jul 2023 02:04:23 +0000 Gerrit-HasComments: Yes
