Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 13: (6 comments) http://gerrit.cloudera.org:8080/#/c/19620/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19620/12//COMMIT_MSG@17 PS12, Line 17: tablet_copy_support_download_superblock_in_ba > tablet_copy_support_download_superblock_in_batch ? Done http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc@9456 PS12, Line 9456: superblock_in_b > Is it necessary? No necessary. I will remove it. http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc@9458 PS12, Line 9458: // --rpc_max_message_size can be set a small value. : "--rpc_max_message_size_enable_validation=false " : // Set --rpc_max_message_size very sma > I guess they are not necessary on client side, add comments to explain why It is necessary. Disable --rpc_max_message_size_enable_validation, so --rpc_max_message_size can be set a small value. Set --rpc_max_message_size very small, so it is easy for the size of superblock over --rpc_max_message_size. It is used to repeat the network error, see line 9477. --consensus_max_batch_size_bytes and --rpc_max_message_size are in a group flag validator, so it is also should be set a small value. http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc@9471 PS12, Line 9471: > larger? Done http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_client.cc@148 PS12, Line 148: "); : > Remove this, it's duplicate. Done http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_service.cc File src/kudu/tserver/tablet_copy_service.cc: http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_service.cc@217 PS12, Line 217: --rpc_max_message_si > nit: --rpc_max_message_size Done -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 13 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 05 Jul 2023 10:07:43 +0000 Gerrit-HasComments: Yes
