Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/19620/8/src/kudu/tserver/tablet_copy.proto File src/kudu/tserver/tablet_copy.proto: http://gerrit.cloudera.org:8080/#/c/19620/8/src/kudu/tserver/tablet_copy.proto@100 PS8, Line 100: auto_download_superblock_in_ > Done optional bool download_superblock_in_batch = 3 [default = false]; And maybe rename to support_download_superblock_in_batch_feature or sth? http://gerrit.cloudera.org:8080/#/c/19620/8/src/kudu/tserver/tablet_copy.proto@127 PS8, Line 127: superblock_is_too_large > Done optional bool superblock_is_too_large = 7 [default = false]; http://gerrit.cloudera.org:8080/#/c/19620/8/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19620/8/src/kudu/tserver/tablet_copy_client.cc@146 PS8, Line 146: tablet_copy_auto_download_superblock_in_ > Isn't it automatically, why still need this flag? Missing this? I think this flag can be removed, set the field in request to true directly. -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 04 Jul 2023 12:33:55 +0000 Gerrit-HasComments: Yes
