Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c/19620/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19620/12//COMMIT_MSG@17 PS12, Line 17: tablet_copy_auto_download_superblock_in_batch tablet_copy_support_download_superblock_in_batch ? http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc@9456 PS12, Line 9456: -num_threads=3 Is it necessary? http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc@9458 PS12, Line 9458: "--rpc_max_message_size_enable_validation=false " : "--rpc_max_message_size=$5 " : "--consensus_max_batch_size_bytes=$6 " I guess they are not necessary on client side, add comments to explain why adding them? http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tools/kudu-tool-test.cc@9471 PS12, Line 9471: less larger? http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_client.cc@148 PS12, Line 148: the default value " : "is true. Remove this, it's duplicate. http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_service.cc File src/kudu/tserver/tablet_copy_service.cc: http://gerrit.cloudera.org:8080/#/c/19620/12/src/kudu/tserver/tablet_copy_service.cc@217 PS12, Line 217: rpc_max_message_size nit: --rpc_max_message_size Remember to update the test as well. -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 05 Jul 2023 09:30:03 +0000 Gerrit-HasComments: Yes
