Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tools/kudu-tool-test.cc@9381 PS6, Line 9381: > nit: remove the space. Done http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_client.cc@928 PS6, Line 928: options > Missing to set is_sensitive? No. Here downloading superblock file without any format. If set is_sensitive, NewTempRWFile() will generate a encrypted file header. http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_client.cc@935 PS6, Line 935: while > It is necessary to add a test to cover the case of the loop actually iterat Done http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_service.cc File src/kudu/tserver/tablet_copy_service.cc: http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_service.cc@208 PS6, Line 208: > The service side is easy to know if the superblock size is larger than --rp Done http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_source_session.cc@324 PS6, Line 324: _util::Wri > Also remove the file when the session closed. Done http://gerrit.cloudera.org:8080/#/c/19620/6/src/kudu/tserver/tablet_copy_source_session.cc@324 PS6, Line 324: RETURN_NOT_OK_PREPEND(pb_util::WritePBContainerToPath( : fs_manager_->env(), superblock_tmp_path_, tablet_superblock_, : > Is it possible 2 tservers copy a same tablet fron the source tserver concur I will rename the superblock using the unique session id to keep thread safety. -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 04 Jul 2023 02:26:00 +0000 Gerrit-HasComments: Yes
