Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20326 )

Change subject: [tools] Enable 'kudu test' CLI tool when -DNO_TESTS=1
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14
PS1, Line 14: This patch enable to build 'kudu test' CLI tool even if
            : -DNO_TESTS=1.
I'm wondering if in some cases this 'test' feature is not so necessary. E.g. 
for production environment deployment. Then there is nothing wrong with the 
existing behavior of '-DNO_TESTS'. Maybe we can add another option for enabling 
the 'kudu test'?



--
To view, visit http://gerrit.cloudera.org:8080/20326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13
Gerrit-Change-Number: 20326
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Tue, 08 Aug 2023 12:45:20 +0000
Gerrit-HasComments: Yes

Reply via email to