Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 )
Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14 PS1, Line 14: This patch enable to build 'kudu test' CLI tool when : -DKUDU_CLI_TO > So, if people are working on Kudu development, they are to build and run te Yifan found this issue [1] when she verified the 1.17.0-RC1 java example, the java example will try to use Kudu CLI tool to start a mini-cluster by using 'kudu test', it will report an error because the published tool is built with '-DNO_TESTS=1' flag [2] and didn't support 'kudu test'. An alternative way to resolve this is to remove the '-DNO_TESTS=1' flag in the script, but too many unnecessary test binaries will be built when build the mini cluster binaries, and the 'KUDU_CLI_TOOL_NO_TESTS' flag is not well used. 1. https://lists.apache.org/thread/5s27j7k51xfg06l8nkxq62ooqq5s0m47 2. https://github.com/apache/kudu/blob/master/build-support/mini-cluster/build_mini_cluster_binaries.sh#L126C20-L126C20 -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 02:29:58 +0000 Gerrit-HasComments: Yes
