Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 )
Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14 PS1, Line 14: This patch enable to build 'kudu test' CLI tool even if : -DNO_TESTS=1. > The 'kudu test' CLI tool has two use cases I can imagine, one is for testin So, if people are working on Kudu development, they are to build and run tests, and the set of existing C++ tests is a part of that. Then they automatically build not specifying the NO_TESTS option, and they get the `kudu test` CLI tool along with multiple test binaries to run various C++ tests. Otherwise, why to build the kudu binary to include the `kudu test` CLI tool, but to not build the tests? In what environment are you going to use that kudu binary then? Where are you going to get the tests to run if you haven't built the rest without NO_TESTS option? I'm not sure I understand, but maybe I'm missing something? -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 09 Aug 2023 23:35:04 +0000 Gerrit-HasComments: Yes
