Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 )
Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14 PS1, Line 14: This patch enable to build 'kudu test' CLI tool when : -DKUDU_CLI_TO > Yifan found this issue [1] when she verified the 1.17.0-RC1 java example, t All right, thanks for the clarification. Indeed: if we want to make sure the binary JAR contains a kudu CLI binary with the'kudu test' tool, we need to have a way to build that, but not build any tests. However, please make sure there is a mode when neither tests, nor mini-cluster and related stuff is built. With the code in PS2, I didn't see how to do so. http://gerrit.cloudera.org:8080/#/c/20326/2/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20326/2/src/kudu/security/CMakeLists.txt@102 PS2, Line 102: is used only for 'kudu test' CLI tool I don't think this is true: IIUC, the mini_kdc is also used in negotiation-test.cc where the 'kudu test' CLI tool isn't used. I'd recommend to keep this (and other related comments) as-is. -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 14 Aug 2023 22:21:44 +0000 Gerrit-HasComments: Yes
