Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 )
Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14 PS1, Line 14: This patch enable to build 'kudu test' CLI tool when : -DKUDU_CLI_TO > All right, thanks for the clarification. You can do that by: cmake -DNO_TESTS=1 -DKUDU_CLI_TOOL_NO_TESTS=1 ../.. But I missed to set the KUDU_CLI_TOOL_NO_TESTS variable in PS2 indeed. In PS3, you can do that by the command above or: cmake -DNO_TESTS=1 ../.. Thanks to your carefully review! http://gerrit.cloudera.org:8080/#/c/20326/2/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20326/2/src/kudu/security/CMakeLists.txt@102 PS2, Line 102: is used only for tests. > I don't think this is true: IIUC, the mini_kdc is also used in negotiation- Done, and with minor updates. -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 15 Aug 2023 03:11:32 +0000 Gerrit-HasComments: Yes
