Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20326 )
Change subject: [tools] Enable 'kudu test' CLI tool when -DKUDU_CLI_TOOL_NO_TESTS=0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20326/1//COMMIT_MSG@14 PS1, Line 14: This patch enable to build 'kudu test' CLI tool even if : -DNO_TESTS=1. > I'm wondering if in some cases this 'test' feature is not so necessary. E.g The idea of removing everything test-related when building with -DNO_TESTS was exactly that: if building release bits, there isn't any need for tests, and there isn't any need to run tests with the `kudu` CLI binary to be used in the production. In that sense, I'm not sure why we need to enable the 'kudu test' CLI tool there, when it's always possible to configure and build Kudu not specifying the -DNO_TESTS option. So far I thought we can either build tests and the kudu CLI tool that is capable of running those tests, or we don't build any C++ tests and the kudu CLI binary doesn't have the 'kudu test' tool correspondingly. Yingchun, could you please clarify on the use case when it's necessary to build the kudu CLI binary with 'kudu test' tool, but not build any C++ tests? -- To view, visit http://gerrit.cloudera.org:8080/20326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I381348b0123f8566d547cdd4449e308ea5f6aa13 Gerrit-Change-Number: 20326 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 09 Aug 2023 01:24:27 +0000 Gerrit-HasComments: Yes
