-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98932
-----------------------------------------------------------



include/mesos/mesos.proto (lines 1163 - 1164)
<https://reviews.apache.org/r/38367/#comment155662>

    Do we have to say that this information is resolved at setup time? What 
about status changes during run time? I'm wondering whether we can leverage 
this for MESOS-3334.



include/mesos/mesos.proto (lines 1369 - 1370)
<https://reviews.apache.org/r/38367/#comment155666>

    s/0/1/
    s/1/2/
    
    enum starting with "0" is bad because it is hard to distinguish the case 
when the enum is not set.



include/mesos/mesos.proto (line 1390)
<https://reviews.apache.org/r/38367/#comment155668>

    s/. E.g./, e.g./



src/common/http.cpp (lines 153 - 194)
<https://reviews.apache.org/r/38367/#comment155672>

    Why custom models? Can we not use the protobuf to json converters?



src/tests/master_tests.cpp (line 3247)
<https://reviews.apache.org/r/38367/#comment155682>

    this test doesn't seem to test label values?



src/tests/master_tests.cpp (line 3320)
<https://reviews.apache.org/r/38367/#comment155679>

    kill this?



src/tests/slave_tests.cpp (line 2223)
<https://reviews.apache.org/r/38367/#comment155681>

    s/an is/is/ ?


- Vinod Kone


On Sept. 14, 2015, 8:55 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 8:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the frameworks to specify an intent to enable ip-per-container. 
> The
> IP information is supplied back to the framework as well as state.json 
> endpoints
> by including NetworkInfo inside TaskStatus.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
>   src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38367/diff/
> 
> 
> Testing
> -------
> 
> Added new tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to