----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98926 -----------------------------------------------------------
include/mesos/mesos.proto (line 1163) <https://reviews.apache.org/r/38367/#comment155653> We still go by 70 col comments, right? If so, let's wrap the comment blocks. include/mesos/mesos.proto (line 1164) <https://reviews.apache.org/r/38367/#comment155669> Wonder if we can enumerate more container information examples that may go into the container status (so it doesn't become a network-only structure) include/mesos/mesos.proto (line 1362) <https://reviews.apache.org/r/38367/#comment155654> Request _and_ resolution, right? Can we capture this here? include/mesos/mesos.proto (line 1365) <https://reviews.apache.org/r/38367/#comment155688> We probably need to have a caveat about the pluggable nature of networking (and that if not enabled, this will be not be interpreted by mesos) include/mesos/mesos.proto (line 1376) <https://reviews.apache.org/r/38367/#comment155683> We should probably mention that it is up to the mesos networking 'provider' to interpret this as either a hint or a requirement for the assigned ip. include/mesos/mesos.proto (line 1386) <https://reviews.apache.org/r/38367/#comment155687> We could mention that these groups can be used for isolation include/mesos/mesos.proto (line 1390) <https://reviews.apache.org/r/38367/#comment155680> pop? :) - Niklas Nielsen On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38367/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 1:55 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-3013 > https://issues.apache.org/jira/browse/MESOS-3013 > > > Repository: mesos > > > Description > ------- > > This allows the frameworks to specify an intent to enable ip-per-container. > The > IP information is supplied back to the framework as well as state.json > endpoints > by including NetworkInfo inside TaskStatus. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 > src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 > src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 > > Diff: https://reviews.apache.org/r/38367/diff/ > > > Testing > ------- > > Added new tests and ran make check. > > > Thanks, > > Kapil Arya > >
