> On Sept. 14, 2015, 6:43 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 2760 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072965#file1072965line2760> > > > > s/the container IP address if/the container IP address with the IP from > > the agent PID, if/ or something that specifies where you are getting the IP > > from. > > > > Would it be more precise to get the IP from the executor PID?
Updated the comment and added a TODO. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98936 ----------------------------------------------------------- On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38367/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 5:06 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-3013 > https://issues.apache.org/jira/browse/MESOS-3013 > > > Repository: mesos > > > Description > ------- > > This allows the frameworks to specify an intent to enable ip-per-container. > The > IP information is supplied back to the framework as well as state.json > endpoints > by including NetworkInfo inside TaskStatus. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 > src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 > src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 > > Diff: https://reviews.apache.org/r/38367/diff/ > > > Testing > ------- > > Added new tests and ran make check. > > > Thanks, > > Kapil Arya > >
