-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98936
-----------------------------------------------------------



src/slave/slave.cpp (line 2760)
<https://reviews.apache.org/r/38367/#comment155697>

    s/the container IP address if/the container IP address with the IP from the 
agent PID, if/ or something that specifies where you are getting the IP from.
    
    Would it be more precise to get the IP from the executor PID?



src/tests/master_tests.cpp (line 3293)
<https://reviews.apache.org/r/38367/#comment155696>

    Can we const this?



src/tests/slave_tests.cpp (line 2269)
<https://reviews.apache.org/r/38367/#comment155694>

    Can we const this string?



src/tests/slave_tests.cpp (line 2271)
<https://reviews.apache.org/r/38367/#comment155695>

    Quite a long piece of straight line code; mind throwing in some comments 
breaking it up a bit and explaining what you are doing?


- Niklas Nielsen


On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38367/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 1:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the frameworks to specify an intent to enable ip-per-container. 
> The
> IP information is supplied back to the framework as well as state.json 
> endpoints
> by including NetworkInfo inside TaskStatus.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
>   src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38367/diff/
> 
> 
> Testing
> -------
> 
> Added new tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to