> On Sept. 14, 2015, 10:19 p.m., Vinod Kone wrote: > > src/common/http.cpp, lines 153-194 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072964#file1072964line153> > > > > Why custom models? Can we not use the protobuf to json converters? > > Kapil Arya wrote: > This is mostly due to Labels. The way they are setup right now, we get > sth like: > ``` > { "labels": { "labels": [ { "key": "k", "value": "v" } ... ] } } > ``` > > The explicit modelling removes the extra label from within the JSON to > make it more readable.
we have a goal to back our admin endpoints (like state.json) with protobufs so that it is easy to convey the schema to the operators. so i would prefer we use standard protobuf to json converters. but, looks like "Labels" is already being modeled in a custom way in the state endpoint. so i'm fine if you want to keep it consistent. feel free to drop the issue. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98932 ----------------------------------------------------------- On Sept. 16, 2015, 2:05 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38367/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 2:05 a.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-3013 > https://issues.apache.org/jira/browse/MESOS-3013 > > > Repository: mesos > > > Description > ------- > > This allows the frameworks to specify an intent to enable ip-per-container. > The > IP information is supplied back to the framework as well as state.json > endpoints > by including NetworkInfo inside TaskStatus. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 > src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 > src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 > src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b > src/tests/slave_tests.cpp 447c43c96ce0c043e37319bb213723ed33820f8a > > Diff: https://reviews.apache.org/r/38367/diff/ > > > Testing > ------- > > Added new tests and ran make check. > > > Thanks, > > Kapil Arya > >
