> On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1163 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1163> > > > > We still go by 70 col comments, right? If so, let's wrap the comment > > blocks.
It's been updated :-) https://github.com/apache/mesos/commit/f9c2604ea97b91f8a9ec3b2863317761679b1c86 > On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1362 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1362> > > > > Request _and_ resolution, right? > > > > Can we capture this here? Fixed. > On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1365 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1365> > > > > We probably need to have a caveat about the pluggable nature of > > networking (and that if not enabled, this will be not be interpreted by > > mesos) Extended the comment. > On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1376 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1376> > > > > We should probably mention that it is up to the mesos networking > > 'provider' to interpret this as either a hint or a requirement for the > > assigned ip. Done. > On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1386 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1386> > > > > We could mention that these groups can be used for isolation Fixed. > On Sept. 14, 2015, 6:24 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1390 > > <https://reviews.apache.org/r/38367/diff/1/?file=1072962#file1072962line1390> > > > > pop? :) Removed. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98926 ----------------------------------------------------------- On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38367/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 5:06 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-3013 > https://issues.apache.org/jira/browse/MESOS-3013 > > > Repository: mesos > > > Description > ------- > > This allows the frameworks to specify an intent to enable ip-per-container. > The > IP information is supplied back to the framework as well as state.json > endpoints > by including NetworkInfo inside TaskStatus. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 > src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 > src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 > > Diff: https://reviews.apache.org/r/38367/diff/ > > > Testing > ------- > > Added new tests and ran make check. > > > Thanks, > > Kapil Arya > >
