> On Nov. 9, 2015, 11:26 p.m., Greg Mann wrote: > > src/master/master.cpp, line 568 > > <https://reviews.apache.org/r/35711/diff/15/?file=1089398#file1089398line568> > > > > Should we add a comment here saying that the validation of roles occurs > > in flags.cpp?
I put off the check to `Master::initialize()` like we check `flags.resources` in `Slave::initialize()` - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review105756 ----------------------------------------------------------- On Dec. 12, 2015, 2:33 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 2:33 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > include/mesos/roles.hpp PRE-CREATION > src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb > src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e > src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 > src/common/roles.cpp PRE-CREATION > src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 > src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 > src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 > src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 > src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399 > src/tests/roles_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
