----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review123207 -----------------------------------------------------------
src/master/main.cpp (line 238) <https://reviews.apache.org/r/44670/#comment185429> Can you prepend `--` for all references to flags in error messages? Here and below. src/master/main.cpp (lines 354 - 366) <https://reviews.apache.org/r/44670/#comment185426> Why not do this: ``` Try <MasterContender*> _contender = nullptr; if (flags.master_contender.isSome()) { _contender = MasterContender::createFromModule(flags.master_contender); } else { _contender = MasterContender::create(zk); } ``` src/master/main.cpp (lines 374 - 386) <https://reviews.apache.org/r/44670/#comment185427> Ditto code re-organization above. src/slave/main.cpp (lines 268 - 279) <https://reviews.apache.org/r/44670/#comment185428> Ditto code re-organization above. - Joseph Wu On March 10, 2016, 3:46 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44670/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 3:46 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > The master_detector and master_contender flags allow modules to be > used for specifying the MasterContender and MasterDetector > implementations to use. > > > Diffs > ----- > > src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 > src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418 > src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe > src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb > > Diff: https://reviews.apache.org/r/44670/diff/ > > > Testing > ------- > > In addition to all unit tests passing, we are currently using this > functionality in our environment with a custom consensus stack. In our world, > we have a C++ plugin that calls out to an HTTP REST service (implemented in > Java/Scala, not that it matters). > > > Thanks, > > Anurag Singh > >
