> On Feb. 10, 2017, 2:42 a.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp
> > Lines 73 (patched)
> > <https://reviews.apache.org/r/56213/diff/3/?file=1627707#file1627707line73>
> >
> >     Any particular reason for using v1 scheduler API? The general 
> > recommendation has been to use v0 scheduler API unless you are testing v1 
> > features. The main reason being most users are still using v0 scheduler API.
> 
> Alexander Rukletsov wrote:
>     My original intention was to use unversioned HTTP API. However, I didn't 
> figure out how to do this and I suspect that it is not even possible. Is it 
> correct, that there are two choices? 
>     1) use older driver-based API
>     2) use newer v1 HTTP API
>     
>     Is the recommendation then to use older driver-based API in tests?
> 
> Vinod Kone wrote:
>     yes, the recommendation is to use v0 scheduler API unless either the rest 
> of the tests in the file are all using v1 scheduler API or you are testing v1 
> scheduler API functionality.

In this file, we will be testing default executor as well, which only supports 
v1. Hence, for consistency, I decided to use V1 for all the tests in the file.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56213/#review165049
-----------------------------------------------------------


On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56213/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 4:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 
>   src/tests/mesos.hpp f39e243c2c11bc1c9c757049fda2122727d1fef9 
> 
> 
> Diff: https://reviews.apache.org/r/56213/diff/7/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56218/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to