----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review165568 -----------------------------------------------------------
src/tests/check_tests.cpp (line 202) <https://reviews.apache.org/r/56213/#comment237423> Add here and in the other tests: `// Ignore subsequent offers.` src/tests/check_tests.cpp (lines 620 - 625) <https://reviews.apache.org/r/56213/#comment237550> This has the potential of being flaky on a very busy box. A more robust approach could set the grace period to MAX_INT, and make the health check pass iff a file created by the check exists. src/tests/check_tests.cpp (line 632) <https://reviews.apache.org/r/56213/#comment237553> I'd add: ``` EXPECT_FALSE(updateTaskRunning->status().has_healthy()); EXPECT_TRUE(updateTaskRunning->status().has_check_status()); EXPECT_TRUE(updateTaskRunning->status().check_status().has_command()); EXPECT_FALSE(updateTaskRunning->status().check_status().command().has_exit_code()); ``` src/tests/check_tests.cpp (line 681) <https://reviews.apache.org/r/56213/#comment237554> s/http/HTTP/ - Gastón Kleiman On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56213/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:56 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c > src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe > > Diff: https://reviews.apache.org/r/56213/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
