Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4844#discussion_r25732399
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala ---
@@ -38,11 +38,11 @@ private[spark] class ApplicationInfo(
extends Serializable {
@transient var state: ApplicationState.Value = _
- @transient var executors: mutable.HashMap[Int, ExecutorDesc] = _
- @transient var removedExecutors: ArrayBuffer[ExecutorDesc] = _
- @transient var coresGranted: Int = _
+ @transient private[master] var executors: mutable.HashMap[Int,
ExecutorDesc] = _
+ @transient private[master] var removedExecutors:
ArrayBuffer[ExecutorDesc] = _
+ @transient private[master] var coresGranted: Int = _
@transient var endTime: Long = _
- @transient var appSource: ApplicationSource = _
+ @transient private[master] var appSource: ApplicationSource = _
--- End diff --
I think this might be going a little too far. It's probably OK for all of
these to just be `private[deploy]`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
