Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4844#issuecomment-76849828
Oh my, I didn't realize this would expand to change 50 files. In many cases
you're removing visibility restrictions. I understand that the class-level
visibility still constrains it but it's part of why the change is large now.
I don't feel qualified to judge whether this is too much change or not. It
seems like the original much smaller commit was certainly a good change, at the
least. I agree that it does feel right to lock down visibility to improve
reasoning about the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
