Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/4844#issuecomment-77086116
Hi, @andrewor14 , thank you very much for the comments
* For your first concern, it's quiet reasonable, so I just changed the
code again to loose some accessibility restrictions of the fields/methods.
But I still keep some of them, which mainly stay in
`master.ApplicationInfo` and `deploy.SparkSubmit`
The reason is that 1) for SparkSubmit, those methods are just accessed
by the object itself as well as the unit test suite...I guess leaving them to
be accessible across the whole code base is not that "elegant"? 2) for
ApplicationInfo...it's more than "elegance", I think we may not wish the
classes from outside of master package can change the internal status of
ApplicationInfo instance?
* For your second concern, actually
https://github.com/apache/spark/pull/4844/files#diff-a240aa7b4630dc389590147f96cf3431R61
is a nested class of `private[spark] class AppClient` and is only used
locally.....so let's keep this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
