Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4844#issuecomment-77048790
@CodingCat I'm in full support for the changes that involve changing `var
x` to `private var x` where possible. I think it's fine to tighten
`private[spark] class X` to `private[...] class X`, but doing it on a
per-method or field basis seems a little too much without obvious readability
benefits. One thing I'm not so sure about is changing otherwise public APIs
`class X` to `private[spark] X`, which technically breaks backward
compatibility for those classes or objects (e.g. `o.a.s.deploy.Client`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
