Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/4844#issuecomment-76847322
Hi, @srowen and @JoshRosen
I made further changes. Basically, I got 2 kinds of strategies to tighten
the accessibility
1. modify individual variables/methods
2. change the accessibility of the classes directly
One more thing to mention is that
I didn't apply the most restrict permission to all places, because I guess
in some of the places, the original authors intentionally made more loose
accessibility for easier extension in future, e.g. in
https://github.com/apache/spark/pull/4844/files#diff-829a8674171f92acd61007bedb1bfa4fR40
(DriverRunner), some of the public variables declared in the constructor is
not necessary (e.g. workerUrl), but some of the public variables declared
together is read in other classes (e.g. driverId is read in WorkerPage), in
such cases, I didn't limit workerUrl as private, since in future we might add
more rich content to WorkerPage....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
