Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/5085#issuecomment-84165646
  
    I talked to @nishkamravi2 offline, and we agreed on a different approach: 
getting rid of the launcher library (the perf difference not being in any way 
worrisome), and passing the location of the assembly file to the launcher's 
`Main` class.
    
    That way the logic to find the assembly (still with the `*hadoop*` 
restriction) replaces the logic to find the launcher in the scripts, and the 
launcher library doesn't need code to look for the assembly, which should make 
use cases similar to his easier to handle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to