amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995329940
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
yes I was following existing practice.
The proto itself evolves fast. We need a lot more documentation on protobuf
once it becomes stable a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
