stefankandic commented on PR #49425: URL: https://github.com/apache/spark/pull/49425#issuecomment-2580797873
> +1, the proposal sounds reasonable and this PR handles all instances in non-test code. > > > To be able to have this centralized and not have to create new string literals with "UTF8_BINARY" over and over again. > > BTW, I'm just wondering if you happen to know a way which we can remove the repetition completely from the test code too. > > ``` > $ git grep "\"UTF8_BINARY\"" | grep Collation | wc -l > 992 > ``` > > Thank you, @stefankandic . There is one suite accounting for almost 700 of those (CollationSupportSuite), so ideally we should refactor it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
