dongjoon-hyun commented on PR #49425: URL: https://github.com/apache/spark/pull/49425#issuecomment-2580896568
Could you run `dev/lint-java` and fix all `LineLength` errors? Otherwise, the CI will fail due to this. ``` $ dev/lint-java Using `mvn` from path: /Users/dongjoon/APACHE/spark-merge/build/apache-maven-3.9.9/bin/mvn Using SPARK_LOCAL_IP=localhost Checkstyle checks failed at following occurrences: [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[162] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[163] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[169] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[170] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1132] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1133] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1135] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1139] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1142] (sizes) LineLength: Line is longer than 100 characters (found 104). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1143] (sizes) LineLength: Line is longer than 100 characters (found 107). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1523] (sizes) LineLength: Line is longer than 100 characters (found 107). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1784] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1785] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1787] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1788] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1789] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1791] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1792] (sizes) LineLength: Line is longer than 100 characters (found 107). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1793] (sizes) LineLength: Line is longer than 100 characters (found 106). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1794] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1795] (sizes) LineLength: Line is longer than 100 characters (found 106). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1857] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1858] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[1860] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2075] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2076] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2622] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2624] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2630] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2632] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2634] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2636] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2642] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2644] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2647] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[2649] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3734] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3735] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3737] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3750] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3751] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3753] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3754] (sizes) LineLength: Line is longer than 100 characters (found 104). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3755] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3757] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3800] (sizes) LineLength: Line is longer than 100 characters (found 112). [ERROR] src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:[3801] (sizes) LineLength: Line is longer than 100 characters (found 105). ``` In addition, shall we reuse the static constants by `import` instead of defining new variables like `private final String`? ``` +import static org.apache.spark.sql.catalyst.util.CollationFactory.UNICODE_CI_COLLATION_NAME; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UNICODE_COLLATION_NAME; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UTF8_BINARY_COLLATION_NAME; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UTF8_LCASE_COLLATION_NAME; ``` ``` - private final String UTF8_BINARY_COLLATION_NAME = CollationFactory.UTF8_BINARY_COLLATION_NAME; - private final String UTF8_LCASE_COLLATION_NAME = CollationFactory.UTF8_LCASE_COLLATION_NAME; - private final String UNICODE_COLLATION_NAME = CollationFactory.UNICODE_COLLATION_NAME; - private final String UNICODE_CI_COLLATION_NAME = CollationFactory.UNICODE_CI_COLLATION_NAME; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
