dongjoon-hyun commented on code in PR #49425: URL: https://github.com/apache/spark/pull/49425#discussion_r1909253274
########## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ########## @@ -19,6 +19,10 @@ import org.apache.spark.SparkException; import org.apache.spark.sql.catalyst.util.CollationAwareUTF8String; import org.apache.spark.sql.catalyst.util.CollationFactory; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UNICODE_CI_COLLATION_NAME; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UNICODE_COLLATION_NAME; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UTF8_BINARY_COLLATION_NAME; +import static org.apache.spark.sql.catalyst.util.CollationFactory.UTF8_LCASE_COLLATION_NAME; Review Comment: Did this pass `lint-java` too? I thought all `import static` should go to the bottom like `import static org.junit.jupiter.api.Assertions.*;`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
