stefankandic commented on code in PR #49425:
URL: https://github.com/apache/spark/pull/49425#discussion_r1909177181
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -1113,6 +1113,13 @@ public CollationIdentifier identifier() {
public static final List<String> SUPPORTED_PROVIDERS =
List.of(PROVIDER_SPARK, PROVIDER_ICU);
public static final String COLLATION_PAD_ATTRIBUTE = "NO_PAD";
+ public static final String UTF8_BINARY_COLLATION_NAME =
+ Collation.CollationSpecUTF8.UTF8_BINARY_COLLATION_NAME;
+ public static final String UTF8_LCASE_COLLATION_NAME =
+ Collation.CollationSpecUTF8.UTF8_LCASE_COLLATION_NAME;
+ public static final String UNICODE_COLLATION_NAME = "UNICODE";
+ public static final String UNICODE_CI_COLLATION_NAME = "UNICODE_CI";
Review Comment:
Yes, those are the 4 most used collations so especially if we wanted to
refactor that suite we should centralize the names for all of those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
