MaxGekk commented on code in PR #49425:
URL: https://github.com/apache/spark/pull/49425#discussion_r1910196671
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -1113,6 +1113,13 @@ public CollationIdentifier identifier() {
public static final List<String> SUPPORTED_PROVIDERS =
List.of(PROVIDER_SPARK, PROVIDER_ICU);
public static final String COLLATION_PAD_ATTRIBUTE = "NO_PAD";
+ public static final String UTF8_BINARY_COLLATION_NAME =
Review Comment:
How about to add new class `CollationNames` with those constants to
`org.apache.spark.sql.catalyst.util`:
```java
public class CollationNames {
public static final String UTF8_BINARY = ...
```
BTW, the suffix `_COLLATION_NAME` could be eliminated I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
