nchammas commented on code in PR #57763:
URL: https://github.com/apache/spark/pull/57763#discussion_r3713650397
##########
python/packaging/classic/setup.py:
##########
@@ -342,14 +342,7 @@ def run(self):
package_data={
"pyspark.jars": ["*.jar"],
"pyspark.bin": ["*"],
- "pyspark.sbin": [
- "spark-config.sh",
- "spark-daemon.sh",
- "start-connect-server.sh",
- "start-history-server.sh",
- "stop-connect-server.sh",
- "stop-history-server.sh",
- ],
+ "pyspark.sbin": ["*"],
Review Comment:
Yes, we wanted to prevent users from using PySpark to start a standalone
cluster. I tried to address this with [a clearer
README](https://github.com/apache/spark/pull/57452#discussion_r3635301417) so
that we can just package everything. In other words, I think it's easier to
control this via our support policy instead of via "hard" packaging changes.
Switching to `*` means we will package `sbin/start-{thriftserver, master,
worker}.sh` in addition to the existing scripts we are already packaging today.
These newly packaged scripts can also be called by [the new
CLI](https://github.com/apache/spark/pull/57313) if/when we merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
