gaogaotiantian commented on PR #57763: URL: https://github.com/apache/spark/pull/57763#issuecomment-5261758019
Okay I believe a general rule is - if you can avoid giving users the wrong tools, you should not give them the tools and tell them not to use them. You won't give a child a knife and tell them - please don't use it, I'm not responsible for it. Documentation is the last stop. Sure we can claim that we told the users not to use them, but that won't make the users happier. "I told you so" is a bad user experience. We are not lawyers. If we have to ship something to users that they are not supposed to use, sure we can somehow put the words somewhere (that users may never get the chance to read it). But for anyone who has been working on open source projects for a while, it's an inevitable fact that any internal details will become a public binding after enough time. So this is a tradeoff. We ship something users are not supposed to use, which is obviously bad. What do we gain from shipping them? Is it something we can get from another way? Is it important to us that it could save us a lot of time and trouble? Will it impact users in other ways? To the specific issue you raised - it actually does not matter (that much). The file will be picked up in `sdist` if it appears in either `MANIFEST.in` or `package_data`. It's nice to keep consistency but it's probably not necessary. We also have a `pip test` to catch packaging issues. So I don't see a clear benefit from doing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
