nchammas commented on PR #57763: URL: https://github.com/apache/spark/pull/57763#issuecomment-5262613111
I agree with this general rule but don't see that it applies so strongly in this case. sbin scripts are for end-users. We already package them all in our "full" distributions of Spark. PySpark is the exception. (It's not even clear to me why we wouldn't support users launching "real" clusters with PySpark since the JARs are the same, but that's a separate issue.) > The file will be picked up in sdist if it appears in either MANIFEST.in or package_data. I didn't realize this and just tested it to confirm. This is also [documented][1]: > Note that the data files specified using the `package_data` option neither require to be included within a [MANIFEST.in](https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html#using-manifest-in) file, nor require to be added by a revision control system plugin. In this case I would want us to remove anything from MANIFEST.in that doesn't need to be there, because the duplicate entries across setup.py and MANIFEST.in are a source of confusion. I will submit a PR for that and set aside this proposal for now. [1]: https://setuptools.pypa.io/en/latest/userguide/datafiles.html#package-data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
