uros-b commented on code in PR #57763:
URL: https://github.com/apache/spark/pull/57763#discussion_r3719270391
##########
python/packaging/classic/setup.py:
##########
@@ -342,14 +342,7 @@ def run(self):
package_data={
"pyspark.jars": ["*.jar"],
"pyspark.bin": ["*"],
- "pyspark.sbin": [
- "spark-config.sh",
- "spark-daemon.sh",
- "start-connect-server.sh",
- "start-history-server.sh",
- "stop-connect-server.sh",
- "stop-history-server.sh",
- ],
+ "pyspark.sbin": ["*"],
Review Comment:
@nchammas Please note that switching from an explicit whitelist to ["*"] /
graft deps/sbin adds 13 cluster-management scripts (start-all.sh, stop-all.sh,
start-master.sh, stop-master.sh, start-workers.sh, stop-workers.sh,
start-worker.sh, stop-worker.sh, start-thriftserver.sh, stop-thriftserver.sh,
decommission-worker.sh, spark-daemons.sh, workers.sh) that were deliberately
excluded in the original #23715 discussion due to concerns about users trying
to start full clusters from a pip-installed package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
