gaogaotiantian commented on PR #57763: URL: https://github.com/apache/spark/pull/57763#issuecomment-5240688829
I think we have a pip test somewhere to test packaging? Yes it would be nice to make sure `MANIFEST.in` syncs with `setup.py`. I'm more worried about future. In a few months this packaging detail might be forgotten (or never noticed). People may add new "dev-only" scripts to `sbin` and accidentally ship it. I'm not saying this is a huge deal breaker. I just like explicit allow list than wildcards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
