Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1476#discussion_r15098545
--- Diff:
core/src/test/scala/org/apache/spark/ui/jobs/JobProgressListenerSuite.scala ---
@@ -81,8 +81,6 @@ class JobProgressListenerSuite extends FunSuite with
LocalSparkContext with Matc
assert(listener.stageIdToData.size === 1)
// finish this task, should get updated duration
- shuffleReadMetrics.remoteBytesRead = 1000
- taskMetrics.shuffleReadMetrics = Some(shuffleReadMetrics)
--- End diff --
It expects 2000 bytes read because the listener is adding up the total
across all tasks in the stage -- so 1000 for the earlier task + 1000 for this
task. The lines that I deleted were redundant (remoteBytesRead was already set
to 1000 and shuffleReadMetrics had already been set as
taskMetrics.shuffleReadMetrics).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
