Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1476#discussion_r15099340
--- Diff:
core/src/test/scala/org/apache/spark/ui/jobs/JobProgressListenerSuite.scala ---
@@ -81,8 +81,6 @@ class JobProgressListenerSuite extends FunSuite with
LocalSparkContext with Matc
assert(listener.stageIdToData.size === 1)
// finish this task, should get updated duration
- shuffleReadMetrics.remoteBytesRead = 1000
- taskMetrics.shuffleReadMetrics = Some(shuffleReadMetrics)
--- End diff --
Ahh, gotcha, apologies. Any chance we could get a new unit test for the
particular problem in this PR? The changes you added do look correct and
verifiable from just reading them, so I'd be fine with this being merged
without, but doesn't hurt to ask :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
