Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1476#discussion_r15119268
--- Diff:
core/src/test/scala/org/apache/spark/ui/jobs/JobProgressListenerSuite.scala ---
@@ -81,8 +81,6 @@ class JobProgressListenerSuite extends FunSuite with
LocalSparkContext with Matc
assert(listener.stageIdToData.size === 1)
// finish this task, should get updated duration
- shuffleReadMetrics.remoteBytesRead = 1000
- taskMetrics.shuffleReadMetrics = Some(shuffleReadMetrics)
--- End diff --
The test I changed in SparkListenerSuite tests this problem (since before
the test only checked that the value is > 0, and I changed it to test for the
correct value -- the updated test fails with the old code). Were you thinking
to break this issue out into its own test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
